Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed reporting error without event crashing reporter #7702

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fixed reporting error without event crashing reporter #7702

merged 1 commit into from
Nov 21, 2023

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Nov 20, 2023 •
edited
Loading

Fixes #7697

Basically, reported_error.event can be None.

🙂 Re-running Windows tests due to #7701 (fixed in #7703)
🙁 Re-running Windows tests again due to #7701 (fixed in #7703)

@qstokkink qstokkink marked this pull request as ready for review November 20, 2023 15:38
@qstokkink qstokkink requested review from a team and egbertbouman and removed request for a team November 20, 2023 15:38
@qstokkink qstokkink changed the title WIP: Fixed reporting error without event crashing reporter READY: Fixed reporting error without event crashing reporter Nov 20, 2023
@qstokkink qstokkink changed the title READY: Fixed reporting error without event crashing reporter Fixed reporting error without event crashing reporter Nov 21, 2023
@qstokkink qstokkink merged commit 1adfe20 into Tribler:main Nov 21, 2023
29 checks passed
@qstokkink qstokkink deleted the fix_none_event branch November 21, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stuck on "SENDING..." when submitting a crash report
2 participants
@qstokkink @egbertbouman